[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

Yonghong Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 5 17:34:11 PDT 2021


yonghong-song added a comment.

@aaron.ballman We discussed internally and I think your concern of mixing type attribute and decl attribute is valid. In the long run, having two separate attributes, one for type (btf_type_tag) and another for decl (btf_decl_tag) seems clean and better. I have crafted one POC patch https://reviews.llvm.org/D111199, could you take a look at the approach? Also, the D111199 <https://reviews.llvm.org/D111199> has hack about storing btf_type_tag string in the AST, I would really appreciate if you can give some advice how to deal with it. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110127/new/

https://reviews.llvm.org/D110127



More information about the cfe-commits mailing list