[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8923-8937
+    // Extract map information.
+    for (const auto *C : Dir.getClausesOfKind<OMPMapClause>()) {
+      if (C->getMapType() != OMPC_MAP_to)
+        continue;
+      for (auto L : C->component_lists()) {
+        const ValueDecl *VD = std::get<0>(L);
+        const auto *RD = VD ? VD->getType()
----------------
jyu2 wrote:
> ABataev wrote:
> > What if we have `to(lambda)` in data motion directive? What shall we do if there mapping modifiers? Not sure we shall ignore them.
> to(lambda) is not isOpenMPTargetExecutionDirective.  I don't see generateInfoForLambdaCaptures and adjustMemberOfForLambdaCaptures functions  get called in that part.  Those two functions only called in emitTargetCall. 
>  So I don't think we need that.
> What do you think? 
> Thanks.
> Jennifer
Ok, let's skip it for now but still need to keep in mind to fix/implement it in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111115/new/

https://reviews.llvm.org/D111115