[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 5 01:03:48 PDT 2021


Ahh, sorry, I thought you meant the other one :( Apologies for confusion

On Tue, Oct 5, 2021 at 9:58 AM Sam McCall via Phabricator <
reviews at reviews.llvm.org> wrote:

> sammccall added inline comments.
>
>
> ================
> Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17
>
> +#include "llvm/ADT/DenseMap.h"
>  #include <cstdint>
> ----------------
> kbobyrev wrote:
> > sammccall wrote:
> > > you only need DenseMapInfo here
> > I think I do need utility because I'm using `std::pair`
> I meant this file can include DenseMapInfo.h instead of DenseMap.h. Fixed
> in 4e91035387faf9e18134b1d46ce0fa803a6e9122
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D110925/new/
>
> https://reviews.llvm.org/D110925
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211005/c8715a0c/attachment.html>


More information about the cfe-commits mailing list