[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 4 17:54:13 PDT 2021


MaskRay added a comment.
Herald added a reviewer: ctetreau.

In D110663#3029577 <https://reviews.llvm.org/D110663#3029577>, @phosek wrote:

> This is going to break Fuchsia as implemented. We assume that `{x86_64,aarch64}-unknown-fuchsia` and `{x86_64,aarch64}-fuchsia` behave identically and developers are allowed to use whichever spelling they prefer. With this change that's no longer true. This may break other platforms that make similar assumptions.

Are Fuchsia developers specifying `--target=` explicitly? I think that's the direction we don't want to support.

>From my understanding of D110900 <https://reviews.llvm.org/D110900>, if a Linux distro prefers `*-linux` to `*-linux-gnu`, we should drop `--target=` normalization to make this available.

I can special case Fuchsia to use the normalized triple, but that's code that I want to avoid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110663/new/

https://reviews.llvm.org/D110663



More information about the cfe-commits mailing list