[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 4 10:39:22 PDT 2021


nickdesaulniers added a comment.

In D107613#3040402 <https://reviews.llvm.org/D107613#3040402>, @dschuff wrote:

> It looks like this error is intended to catch mismatches for attributes that can affect codegen such as noreturn (in which case it makes sense to have it as an error) but it also now fires for cases such as `__attribute__(warning())` which often do not duplicate the attribute on the definition. Is that intended?

Duplicating the attribute on the definition is not needed for `__attribute__(warning())`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107613/new/

https://reviews.llvm.org/D107613



More information about the cfe-commits mailing list