[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

Denys Petrov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 4 08:17:43 PDT 2021


ASDenysPetrov abandoned this revision.
ASDenysPetrov added a comment.

In D97874#3014922 <https://reviews.llvm.org/D97874#3014922>, @martong wrote:

> @ASDenysPetrov I think the dependent patch https://reviews.llvm.org/D97296 is too much and contains unnecessary things for this change.
>
> If you could you please incorporate the minimum needed changes from that patch to here then this patch could land.
> If I am not mistaken then we need only the below changes:
>
>   SVal evalCastKind(ProgramStateRef State, UndefinedVal V, QualType CastTy,
>   SVal evalCastSubKind(ProgramStateRef State, nonloc::SymbolVal V,

This patch is an old one. I believe it is already irrelevant and has to be reviewed once again by me as an author, since it were a lot of improvements made for `ConstraintManager`. Indeed it has a big parent revision, which also need a revision. There was my idea about adding a `ProgramState` inside `evalCast` to make symbolic values more transparent for casts. Let me mark it as //Abandoned// for now. I'll return back to it ASAP. Thank you for attention to this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97874/new/

https://reviews.llvm.org/D97874



More information about the cfe-commits mailing list