[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

Whisperity via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 4 04:47:53 PDT 2021


whisperity added a comment.

In D110614#3038519 <https://reviews.llvm.org/D110614#3038519>, @carlosgalvezp wrote:

> Hi! Are there any more issues I should address? It would be nice to get it merged since it fixes quite a few FPs.

I'm not seeing anything immediate to add. I like the proper printing with the template parameters. 🙂
Just in case: add another set of tests where the template instantiation (both diagnosed and not diagnosed) is behind a `typedef`, just to see how well the diagnostic is printed and generated. Otherwise, I'm happy with this.

> `// Fixes https://bugs.llvm.org/show_bug.cgi?id=51912`

I still think that maybe this whole fiasco is worth either a bug report against `Sema` on its own, or just a question-phrased mail to `cfe-dev`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110614/new/

https://reviews.llvm.org/D110614



More information about the cfe-commits mailing list