[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 3 12:00:51 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: clang/lib/CodeGen/CGExpr.cpp:4911
+      if (!Clone) {
+        Clone = llvm::Function::Create(Fn->getFunctionType(), Fn->getLinkage(),
+                                       Fn->getAddressSpace(),
----------------
given the reported ICE, I wonder if we shouldn't be reusing the `Fn`'s linkage, but explicitly setting extern? Same with below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111009/new/

https://reviews.llvm.org/D111009



More information about the cfe-commits mailing list