[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

Sun Oct 3 02:05:26 PDT 2021

carlosgalvezp marked 3 inline comments as done.
carlosgalvezp added a comment.

Hi! Are there any more issues I should address? It would be nice to get it merged since it fixes quite a few FPs.

Tagging also @mgartmann as original author of this check in case he wants to comment.

Anyway this check will need to be extended in the future, since the C++ Core Guidelines has added a new bullet in their "Enforcement" section:
https://github.com/isocpp/CppCoreGuidelines/commit/e44a9fcbd40923e9d5d342e444cf8a811e4a3eae

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110614/new/

https://reviews.llvm.org/D110614