[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

Zarko Todorovski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 1 14:15:32 PDT 2021


ZarkoCA marked an inline comment as done.
ZarkoCA added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:3178
+      : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) *           \
+         (vector float)(vector unsigned)((0x7f - (__b)) << 23 & 0x1F)),        \
+        vector signed long long                                                \
----------------
nemanjai wrote:
> Hmm... aren't you truncating the wrong thing here (and for all the other shifted ones? Shouldn't it be something like:
> ```
> (vector float)(vector unsigned)((0x7f - ((__b) & 0x1F)) << 23)),
> ```
Thanks, I wasn't doing the truncation correctly. Redid to what I think is correct now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106409/new/

https://reviews.llvm.org/D106409



More information about the cfe-commits mailing list