[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

Denys Petrov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 1 01:51:15 PDT 2021


ASDenysPetrov added a comment.

In D110625#3035616 <https://reviews.llvm.org/D110625#3035616>, @steakhal wrote:

> 'using' is the same as 'typedef' AFAIK.
> So, you could simply use only typedefs and implement the test in the c test file. Seeing all the tests close together would aid readability IMO.

You're right. I'm OK with `typedef`.

> WDYT Denys? Btw does the SVval::getType return a canonical type in all cases?

`SVval::getType` returns a `QualType` which can be aliased and cv-qualified. So, I may mismatch in comparison `BT->getPointeeType() == elementType`. That is my concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110625/new/

https://reviews.llvm.org/D110625



More information about the cfe-commits mailing list