[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 30 12:35:22 PDT 2021


HazardyKnusperkeks added a comment.

In D110833#3033849 <https://reviews.llvm.org/D110833#3033849>, @MyDeveloperDay wrote:

> I feel this is going the way of BraceWrapping  in that it should be:
>
>   SpaceBeforeParens:
>      - BeforeMacro: false
>      - BeforeFunction: true

So replace the enum with a struct? Yeah I think that's the way. For what it is here proposed it seems that there needs to be a `BeforeFunctionDeclaration` and `BeforeFunctionDefinition`.

It should also make the code easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110833/new/

https://reviews.llvm.org/D110833



More information about the cfe-commits mailing list