[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

Amy Kwan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 30 06:31:35 PDT 2021


amyk added a comment.

Additional nit regarding the description and comment:

The signatures for the PowerPC builtins lharx and
lbarx are incorrect, and causes issues when in a function
that requiers the return of the builtin to be promoted.
This patch fixes these signatures.

Updated to:

The signatures for the PowerPC builtins lharx and
lbarx are incorrect, and causes issues when used in a function
that requires the return of the builtin to be promoted.
This patch fixes these signatures.



================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:50
+
+// extra test cases that previously caused error during usage
+int test_lharx_intret(volatile short *a) {
----------------
nit: Capitalize the sentence and add a period. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110273/new/

https://reviews.llvm.org/D110273



More information about the cfe-commits mailing list