[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 30 05:50:16 PDT 2021


ymandel added a comment.

Looks good! Please add a test to be sure it compiles/works correctly. Thanks!



================
Comment at: clang/include/clang/AST/ASTTypeTraits.h:56
   /// Construct an identifier for T.
-  template <class T>
-  static ASTNodeKind getFromNodeKind() {
+  template <class T> static ASTNodeKind getFromNodeKind() {
     return ASTNodeKind(KindToKindId<T>::Id);
----------------
Here and below -- looks like clang format did this? I'd recommend you revert this line and others like it -- only change formatting on lines you've otherwise edited.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110586/new/

https://reviews.llvm.org/D110586



More information about the cfe-commits mailing list