[PATCH] D110801: [clang-format] [docs] [NFC] improve clarity in the QualifierAlignment warning
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 30 02:32:43 PDT 2021
MyDeveloperDay updated this revision to Diff 376140.
MyDeveloperDay added a comment.
Try and improve the wordage
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110801/new/
https://reviews.llvm.org/D110801
Files:
clang/docs/ClangFormatStyleOptions.rst
clang/include/clang/Format/Format.h
Index: clang/include/clang/Format/Format.h
===================================================================
--- clang/include/clang/Format/Format.h
+++ clang/include/clang/Format/Format.h
@@ -1898,7 +1898,11 @@
/// Different ways to arrange const/volatile qualifiers.
/// \warning
- /// ``QualifierAlignment`` COULD lead to incorrect code generation.
+ /// Setting ``QualifierAlignment`` to something other than `Leave`, COULD
+ /// lead to incorrect code formatting due to incorrect decisions made due to
+ /// clang-formats lack of complete semantic information.
+ /// As such extra care should be taken to review code changes made by the use
+ /// of this option.
/// \endwarning
/// \version 14
QualifierAlignmentStyle QualifierAlignment;
Index: clang/docs/ClangFormatStyleOptions.rst
===================================================================
--- clang/docs/ClangFormatStyleOptions.rst
+++ clang/docs/ClangFormatStyleOptions.rst
@@ -3238,7 +3238,11 @@
.. warning::
- ``QualifierAlignment`` COULD lead to incorrect code generation.
+ Setting ``QualifierAlignment`` to something other than `Leave`, COULD
+ lead to incorrect code formatting due to incorrect decisions made due to
+ clang-formats lack of complete semantic information.
+ As such extra care should be taken to review code changes made by the use
+ of this option.
Possible values:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110801.376140.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210930/ef7ccfde/attachment.bin>
More information about the cfe-commits
mailing list