[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

So for some reason, in Sema, the following returns True:

`dtor->isVirtual() `

However the clang-tidy matcher :

`has(cxxDestructorDecl(isPublic(), isVirtual())),`

Doesn't match this, and that's why we get the FPs. Why would that be, isn't `isVirtual` doing the same as `dtor->isVirtual()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110614/new/

https://reviews.llvm.org/D110614