[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

Zequan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 29 15:03:29 PDT 2021


zequanwu added a comment.

In D85390#3031104 <https://reviews.llvm.org/D85390#3031104>, @rsmith wrote:

> Please see llvm.org/PR52014 -- this patch is not properly handling cv-qualifiers. We should not produce the new note if the destination type has qualifiers that the source type does not possess, because in that case inheritance makes no difference to whether the conversion is valid.

Sent a patch to fix it: D110780 <https://reviews.llvm.org/D110780>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85390/new/

https://reviews.llvm.org/D85390



More information about the cfe-commits mailing list