[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 29 13:18:57 PDT 2021


thakis created this revision.
thakis added a reviewer: hans.
thakis added a project: clang.
thakis requested review of this revision.

Call Driver::getFinalPhase() instead of duplicating it.

https://reviews.llvm.org/D65993 added the duplication, then
02e35832c301e <https://reviews.llvm.org/rG02e35832c301e9813b0bb18e94db2a31c4849a73> maded it more obviously a copy of getFinalPhase().

The only difference is that getCompilationPhases() used to use
LastPhase / IfsMerge where getFinalPhase() used Link. Adapt
getFinalPhase() to return IfsMerge when needed.

No intentional behavior change.


https://reviews.llvm.org/D110770

Files:
  clang/include/clang/Driver/Driver.h
  clang/include/clang/Driver/Phases.h
  clang/include/clang/Driver/Types.h
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/Types.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110770.376021.patch
Type: text/x-patch
Size: 5790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210929/fc2f804e/attachment-0001.bin>


More information about the cfe-commits mailing list