[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from two small nits. As for the modules question, if @rsmith doesn't get back to us, I think it's fine to address that post-commit.



================
Comment at: clang/include/clang/Lex/LiteralSupport.h:233
+      ArrayRef<Token> StringToks, Preprocessor &PP,
+      StringLiteralKind StringKind = StringLiteralKind::Evaluated);
+  StringLiteralParser(ArrayRef<Token> StringToks, const SourceManager &sm,
----------------
aaron.ballman wrote:
> We should rename anything mentioning `StringKind` similarly -- this will also help avoid confusion with the `StringKind` type in Expr.h.
Did this one get missed?


================
Comment at: clang/test/CXX/dcl.dcl/p4-0x.cpp:24
+                     R"x(")x");
\ No newline at end of file

----------------
Can you add the newline back to the end of the file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105759/new/

https://reviews.llvm.org/D105759