[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 29 07:56:25 PDT 2021


tejohnson added a comment.

In D110276#3029952 <https://reviews.llvm.org/D110276#3029952>, @thakis wrote:

> Softlinks don't work on Windows, that's why these tests use copies.
>
> clang_f_opts.c sadly started flaking almost immediately after this went in: http://45.33.8.238/win/46115/step_7.txt
>
> So I fear the Windows file system can't handle this patch as-is.
>
> Maybe we can use `rm -f` and maybe that way the error isn't fatal even when deleting the file doesn't work, not sure.

I can try submitting a change to make it use rm -f. Is this failure on a bot? I didn't get any bot failure notifications.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110276/new/

https://reviews.llvm.org/D110276



More information about the cfe-commits mailing list