[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

[Vaibhav Yenamandra via Phabricator via cfe-commits]

vaibhav.y updated this revision to Diff 375734.
vaibhav.y marked 34 inline comments as done.
vaibhav.y added a comment.

Address comments from upstream review:

- Mark anonymous functions static, improve documentation
- Coding style fixes
- Use Ref types as they are intended (as non-owning lightweight refs)
- SarifDocumentWriter now stores a copy of `clang::LangOptions` passed to it
- getCurrentTool, getCurrentRun return mutable refs instead of raw pointers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109701/new/

https://reviews.llvm.org/D109701

Files:
  clang/include/clang/Basic/Sarif.h
  clang/include/clang/Basic/SourceLocation.h
  clang/lib/Basic/CMakeLists.txt
  clang/lib/Basic/Sarif.cpp
  clang/lib/Basic/SourceLocation.cpp
  clang/unittests/Basic/CMakeLists.txt
  clang/unittests/Basic/SarifTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109701.375734.patch
Type: text/x-patch
Size: 38194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210928/21ec06a7/attachment-0001.bin>