[PATCH] D110422: [AIX] Enable PGO without LTO

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 28 14:01:16 PDT 2021


MaskRay added a comment.

I still think the description can be rephrased to be shorter and clearer, and am not very sure this workaround should be added.
But I will take a vacation and be back after one week and don't want to appear that I am blocking this change.

So LGTM once you decrease the number of `if (TT.isOSBinFormatXCOFF()) {` from two to one.
If you track where `Linkage` and `Visibility` are updated it should be clear one place is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110422/new/

https://reviews.llvm.org/D110422



More information about the cfe-commits mailing list