[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Albion Fung via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 28 12:37:51 PDT 2021


Conanap marked 2 inline comments as done.
Conanap added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4150
+                            0))>;
+def : Pat<(v4i32 (insertelt v4i32:$VEC, DblToUInt.A, 0)),
+          (v4i32 (XXINSERTW v4i32:$VEC,
----------------
nemanjai wrote:
> What am I missing here? It appears to me that this pattern is exactly the same as the one above it. The same appears to be the case for all of these. Also, why the change in naming convention?
This one is for the unsigned version, the above is for the signed version. Originally, using `DblToInt.A` gave me problems as `$A` are now used in two places, so I've changed the other variable names instead. I'll use `DblToInt.B` instead to match the convention, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109902/new/

https://reviews.llvm.org/D109902



More information about the cfe-commits mailing list