[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[Lieberman, Ron via cfe-commits]

[AMD Official Use Only]

Hi George,
I will do it now ...


-----Original Message-----
From: Giorgis Georgakoudis via Phabricator <reviews at reviews.llvm.org> 
Sent: Tuesday, September 28, 2021 1:30 PM
To: georgakoudis1 at llnl.gov; jdoerfert at anl.gov; jhuber6 at vols.utk.edu
Cc: llvm-commits at lists.llvm.org; a335pate at edu.uwaterloo.ca; Singh, Pushpinder <Pushpinder.Singh at amd.com>; Palermo, Dan <Dan.Palermo at amd.com>; Lieberman, Ron <Ron.Lieberman at amd.com>; zhaoshiz at quicinc.com; jonathanchesterfield at gmail.com; josemonsalve2 at gmail.com; chichun.chen at hpe.com; a.bataev at hotmail.com; lebedev.ri at gmail.com; openmp-commits at lists.llvm.org; reviews.llvm.org at jfbastien.com; tianshilei1992 at gmail.com; Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; stefomeister at gmail.com; zhang.guansong at gmail.com; cfe-commits at lists.llvm.org; Balasubrmanian, Vignesh <Vignesh.Balasubrmanian at amd.com>; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; lin32 at llnl.gov; yanliang.mu at intel.com; liao6 at llnl.gov; abidmuslim at gmail.com; sara.royuela at bsc.es; Islam, Saiyedul <Saiyedul.Islam at amd.com>; quic_sourabhs at quicinc.com; deepak.eachempati at hpe.com; dougpuob at gmail.com; xw111luoye at gmail.com; mlekena at skidmore.edu; blitzrakete at gmail.com; jatin.bhateja at gmail.com; greg63706 at gmail.com; shenhan at google.com; ravi.narayanaswamy at intel.com; florian_hahn at apple.com; david.green at arm.com; tra at google.com; Song, Ruiling <Ruiling.Song at amd.com>
Subject: [PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

[CAUTION: External Email]

ggeorgakoudis added a comment.

@pdhaliwal @JonChesterfield @ronlieb I updated the aggregate argument memory allocation to use an alloca instead of malloc'ing in SPMD mode, which should resolve your issue. Could someone please test the updated patch and give me feedback before landing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD102107%2Fnew%2F&data=04%7C01%7Cron.lieberman%40amd.com%7C5b92399e33684f58bb1608d982a599aa%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637684470098601893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1h3%2BMAYI9ectCfTJIp0JIJJjAtwMC7SEQaXypWCTNmc%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD102107&data=04%7C01%7Cron.lieberman%40amd.com%7C5b92399e33684f58bb1608d982a599aa%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637684470098601893%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Y3SeU%2FMG7VqBYv%2FKppem5T4wMP%2F70KeVmU0UD%2F8C1nU%3D&reserved=0