[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 28 10:59:00 PDT 2021


cor3ntin added inline comments.


================
Comment at: clang/lib/Lex/LiteralSupport.cpp:108
+                  unsigned CharWidth, DiagnosticsEngine *Diags,
+                  const LangOptions &Features, bool Unevaluated) {
   const char *EscapeBegin = ThisTokBuf;
----------------
cor3ntin wrote:
> erichkeane wrote:
> > This is like the 3rd time we're using 'Unevaluated' as a bool parameter.  I have a pretty strong preference for making it a scoped-enum in 'Basic' somewhere.
> Any suggestion for where to 
NVM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105759/new/

https://reviews.llvm.org/D105759



More information about the cfe-commits mailing list