[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 28 10:22:18 PDT 2021


tejohnson added a comment.

In D110276#3027955 <https://reviews.llvm.org/D110276#3027955>, @scott.linder wrote:

> Is it possible to use soft links instead of copies? It would still be good to clean up afterwards, but if the host won't allow that cleanup in some cases at least we aren't leaving a big file around.

Possible, but I didn't want to affect the operation of the tests. I don't believe there is any issue with being able to clean up, but I forgot about this patch while waiting for @thakis to confirm that the test failures he saw weren't actually due to this change. I can go ahead and commit this later today if he doesn't get back, and just watch the bots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110276/new/

https://reviews.llvm.org/D110276



More information about the cfe-commits mailing list