[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

[Nemanja Ivanovic via Phabricator via cfe-commits]

nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.

I cannot tell without context whether the codegen changes for the `f32->i32` convert + insert case (for example `@test2` in `test/CodeGen/PowerPC/test-vector-insert.ll`) but it should change.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4145
           (v4i32 (XXINSERTW v4i32:$A, AlignValues.I32_TO_BE_WORD1, 0))>;
+def : Pat<(v4i32 (insertelt v4i32:$VEC, DblToInt.A, 0)),
+          (v4i32 (XXINSERTW v4i32:$VEC,
----------------
I assume this is the big endian Power9 block (and the below is the little endian). However, I can't confirm that since the context for the patch has disappeared somehow.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4150
+                            0))>;
+def : Pat<(v4i32 (insertelt v4i32:$VEC, DblToUInt.A, 0)),
+          (v4i32 (XXINSERTW v4i32:$VEC,
----------------
What am I missing here? It appears to me that this pattern is exactly the same as the one above it. The same appears to be the case for all of these. Also, why the change in naming convention?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109902/new/

https://reviews.llvm.org/D109902