[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

M B via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 28 01:10:11 PDT 2021


bakinovsky-m added a comment.

In D110525#3025314 <https://reviews.llvm.org/D110525#3025314>, @aaron.ballman wrote:

> I'm not certain how, but somehow this review is set to be uneditable, so I cannot mark it as accepted (or close it later once it lands).
>
>> bakinovsky-m created this object with edit policy "Administrators".
>
> I think you may need to edit the review's policy so it goes back to whatever the default is.

My bad, should be editable now

In D110525#3025300 <https://reviews.llvm.org/D110525#3025300>, @aaron.ballman wrote:

> Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, please let me know what name and email address you would like me to use for patch attribution in git.

Yes, please. Name: "M Bakinovsky", email: "mbtrash at yandex.ru"

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110525/new/

https://reviews.llvm.org/D110525



More information about the cfe-commits mailing list