[PATCH] D110485: Support [[no_unique_address]] for all targets.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 27 21:59:41 PDT 2021


rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.

MSVC gets to chose the ABI rules for their platform.  It is not Clang policy to pick ABI rules and then break them later.

If you'd like to contribute an implementation of `[[msvc::no_unique_address]]` that matches MSVC's ABI,  that would be welcome.  I don't know, maybe that's as simple as making it use the existing implementation; @zygoloid might know better.  But "add an ABI feature ahead of the platform owner and then fix the ABI problems later" is not how we do things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110485/new/

https://reviews.llvm.org/D110485



More information about the cfe-commits mailing list