[PATCH] D110482: [clang] Implement if consteval (P1938)

Mon Sep 27 12:26:35 PDT 2021

erichkeane added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5942
   "jump bypasses initialization of VLA type alias">;
 def note_protected_by_constexpr_if : Note<
   "jump enters controlled statement of constexpr if">;
----------------
cor3ntin wrote:
> erichkeane wrote:
> > Oh boy.... this section of 'notes' seem like they deserve some level of merging with a %select.  I'd not want anything other than the `jump enters controlled statemennt of `  variants for this patch though.
> I don't think we can change that without some more refactor.
> see usages of `note_protected_by_constexpr_if`.
> The Diag ID is passed to a `GotoScope` emitting later. No way to pass parameter. Changing that would be unrelated to this PR
good enough for me for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110482/new/

https://reviews.llvm.org/D110482