[PATCH] D108469: Improve handling of static assert messages.

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 27 09:02:00 PDT 2021


jfb added a comment.

Can you test all the values in this? https://godbolt.org/z/h7n54fa5x



================
Comment at: clang/lib/Basic/Diagnostic.cpp:792
+static void pushEscapedString(StringRef Str, SmallVectorImpl<char> &OutStr) {
+  OutStr.reserve(OutStr.size() + Str.size());
+  const unsigned char *Begin =
----------------
Can this addition overflow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108469/new/

https://reviews.llvm.org/D108469



More information about the cfe-commits mailing list