[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added reviewers: erichkeane, rjmccall.
aaron.ballman added a comment.

In general, I think this is shaping up nicely and is almost complete.  I'm adding some additional reviewer though, as this is a somewhat experimental patch for a WG21 proposal that has not been accepted yet and I want to make sure that I'm not missing something. That may also solve the few open questions that still remain.



================
Comment at: clang/lib/AST/Expr.cpp:1110-1111
+    StringLiteralBits.IsPascal = Pascal;
+  }
+  else {
+      StringLiteralBits.CharByteWidth = 1;
----------------
I'd recommend running the entire patch through clang-format though: https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting


================
Comment at: clang/lib/Lex/LiteralSupport.cpp:1542
+  for (const auto &Tok : StringToks) {
+    // Unevaluated string literals can never have a prefix
+    if (Unevaluated && Tok.getKind() != tok::string_literal) {
----------------
aaron.ballman wrote:
> 
Looks like this comment is still missing punctuation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105759/new/

https://reviews.llvm.org/D105759