[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

[Stefan Gränitz via Phabricator via cfe-commits]

sgraenitz added a comment.

Two minor comments. Otherwise LGTM.



================
Comment at: clang/include/clang/Frontend/CompilerInstance.h:223
+  void LoadRequestedPlugins();
+
   /// }
----------------
This could have a minimal doxygen comment now that it's part of the public interface.


================
Comment at: clang/test/Interpreter/plugins.cpp:5
+// RUN:            'extern "C" int printf(const char*,...);' \
+// RUN:            'auto r1 = printf("i = %d\n", i);' 2>&1 | FileCheck %s
+// REQUIRES: host-supports-jit, plugins, examples
----------------
You could write the code interleaved with the check-lines below and then do:
```
// RUN: cat %s | clang-repl | FileCheck %s
```

Is there a good reason not to do so?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110484/new/

https://reviews.llvm.org/D110484