[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 27 05:33:52 PDT 2021


steakhal added a comment.

I appreciate the effort in working on the attribute imports.

Personally, I don't really like this change. IMO `AttrImporter::createImportedAttr()` should do the magic, and apply the necessary glue for the import.
Or we could even create a dedicated function, which would 'just do the right thing' and import the Attr, without the current noise of calling the individual imports than gluing the stuff to the constructor dispatch.

The proposed implementation involves too much code repetition for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110528/new/

https://reviews.llvm.org/D110528



More information about the cfe-commits mailing list