[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 27 04:56:00 PDT 2021
MyDeveloperDay added inline comments.
================
Comment at: clang/docs/tools/dump_format_style.py:218
+ if line.startswith(r'/// \version'):
+ match = re.match(r'/// \\version\s*(?P<version>[0-9.]+)*',line)
+ if match:
----------------
HazardyKnusperkeks wrote:
> HazardyKnusperkeks wrote:
> > This needs to be escaped, doesn't it?
> This shouldn't be needed, or?
I don't think it means any character in a `[...]` but I'm not a regex expert
https://regex101.com/r/0e08JP/1
It is needed because prior to 4.0 we had 3.3->3.9
================
Comment at: clang/include/clang/Format/Format.h:3043
+ /// \endcode
+ /// \version 14
bool ReflowComments;
----------------
HazardyKnusperkeks wrote:
> Some whitespace changes here.
>
> And Version 14 is definitely wrong. It was already in 4 and not in 3.8, don't know how many version were in between.
{F19274652}
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110432/new/
https://reviews.llvm.org/D110432
More information about the cfe-commits
mailing list