[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/docs/tools/dump_format_style.py:218
+      if line.startswith(r'/// \version'):
+        match = re.match(r'/// \\version\s*(?P<version>[0-9.]+)*',line)
+        if match:
----------------
This needs to be escaped, doesn't it?


================
Comment at: clang/docs/tools/dump_format_style.py:218
+      if line.startswith(r'/// \version'):
+        match = re.match(r'/// \\version\s*(?P<version>[0-9.]+)*',line)
+        if match:
----------------
HazardyKnusperkeks wrote:
> This needs to be escaped, doesn't it?
This shouldn't be needed, or?


================
Comment at: clang/include/clang/Format/Format.h:766
   /// If ``true``, ``while (true) continue;`` can be put on a single
-  /// line.
+  /// line
+  /// \version 3.7
----------------
The dot should be kept. Also somehow the output has the dot, but also an A afterwards.


================
Comment at: clang/include/clang/Format/Format.h:2608
   // clang-format off
-  /// Whether to wrap JavaScript import/export statements.
-  /// \code{.js}
-  ///    true:
-  ///    import {
-  ///        VeryLongImportsAreAnnoying,
-  ///        VeryLongImportsAreAnnoying,
-  ///        VeryLongImportsAreAnnoying,
-  ///    } from 'some/module.js'
-  ///
-  ///    false:
-  ///    import {VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying,} from "some/module.js"
-  /// \endcode
-  bool JavaScriptWrapImports;
+ /// Whether to wrap JavaScript import/export statements.
+ /// \code{.js}
----------------
A Space is missing in that block.


================
Comment at: clang/include/clang/Format/Format.h:3043
+      /// \endcode
+  /// \version 14
   bool ReflowComments;
----------------
Some whitespace changes here.

And Version 14 is definitely wrong. It was already in 4 and not in 3.8, don't know how many version were in between.


================
Comment at: clang/include/clang/Format/Format.h:3106
   /// sensitive fashion.
+  /// \version 14
   SortIncludesOptions SortIncludes;
----------------
Was also already in 4, but just as bool.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110432/new/

https://reviews.llvm.org/D110432