[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType
    Akira Hatanaka via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Sun Sep 26 21:06:03 PDT 2021
    
    
  
ahatanak added a reviewer: rjmccall.
ahatanak added a comment.
I'm not sure why `ObjCObjectPointerType` was originally a specifier, but this patch looks safe to me. `ObjCObjectPointerType` is never passed to `TypePrinter::printBefore` and `QualType GetBaseType`, which are the two functions that use `isSpecifierType`, AFAICT.
John, do you remember why it was necessary to make `ObjCObjectPointerType` a specifier type?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110068/new/
https://reviews.llvm.org/D110068
    
    
More information about the cfe-commits
mailing list