[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

Fred Grim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 25 15:34:46 PDT 2021


feg208 added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:17805
+               "    Section{\n"
+               "            0, bar(),\n"
+               "            }\n"
----------------
HazardyKnusperkeks wrote:
> Here is no alignment, maybe add another case with another line?
> 
> What happens if one line has the trailing comma and the next doesn't?
yesh this is pretty ugly. In the second case it crashes. This isn't going to be fixed for a bit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110481/new/

https://reviews.llvm.org/D110481



More information about the cfe-commits mailing list