[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA
Björn Schäpers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 24 13:30:23 PDT 2021
HazardyKnusperkeks added a comment.
In D110432#3021391 <https://reviews.llvm.org/D110432#3021391>, @MyDeveloperDay wrote:
> I agree this looks better
>
> F19213646: image.png <https://reviews.llvm.org/F19213646>
Full support for that. And for the whole change.
================
Comment at: clang/docs/tools/dump_format_style.py:237
+ field_type, field_name, trailcomment, version = re.match(r'([<>:\w(,\s)]+)\s+(\w+)\s*(\/\*version=([0-9.]*)\*\/)*;',
line).groups()
+ option = Option(str(field_name), str(field_type), comment, version)
----------------
I think this was aligned to the opening parenthesis of match(.
If we only had an automatic formatting tool. 😃
================
Comment at: clang/include/clang/Format/Format.h:1865
/// \endwarning
- QualifierAlignmentStyle QualifierAlignment;
+ QualifierAlignmentStyle QualifierAlignment /*version=14.0.0*/;
----------------
Could we move that into the comment block?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110432/new/
https://reviews.llvm.org/D110432
More information about the cfe-commits
mailing list