[PATCH] D110304: [HIP] Fix linking of asanrt.bc

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 24 10:16:38 PDT 2021


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413
       } else
-        BCLibs.push_back(AsanRTL.str());
+        BCLibs.push_back({AsanRTL.str(), false});
     }
----------------
tra wrote:
> Nit: I'd add `/*ShouldInternalize=*/`
will do when committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110304/new/

https://reviews.llvm.org/D110304



More information about the cfe-commits mailing list