[PATCH] D110304: [HIP] Fix linking of asanrt.bc

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/include/clang/Driver/ToolChain.h:116-117
 
+  // Enums corresponding to clang options for linking bitcode, i.e.,
+  // -mlink-builtin-bitcode or -mlink-bitcode-file
+  enum BitCodeLinkOpt {
----------------
tra wrote:
> It appears that what we dealing with here is an on/off switch for whether we want to internalize symbols.
> 
> Perhaps it should be implemented as such. 
> getHIPDeviceLibs() will set the bool flag indicating *what* we want to do with the library and then the toolchain-specific code will decide *how* to make it happen. Currently it translates into specific linking option, but it may be something else. getHIPDeviceLibs does not need to know that.
> 
> The code will remain essentially the same, it's mostly the naming exercise.
> 
> 
will do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110304/new/

https://reviews.llvm.org/D110304