[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

Saiyedul Islam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 23 21:40:27 PDT 2021


saiislam added a comment.

In D110083#3019010 <https://reviews.llvm.org/D110083#3019010>, @MyDeveloperDay wrote:

> Do you mind if I fix the build failures by encasing the codelike section in a .. code::?
>
>   diff --git a/clang/docs/ClangOffloadBundler.rst b/clang/docs/ClangOffloadBundler.rst
>   index 312c45602c99..ac4c5b51904f 100644
>   --- a/clang/docs/ClangOffloadBundler.rst
>   +++ b/clang/docs/ClangOffloadBundler.rst
>   @@ -273,6 +273,8 @@ file will contain device binaries for a host and one or more targets. The
>    output device specific archive is in a format compatible with GNU ar utility
>    and contains a collection of device binaries for a specific target.
>   
>   +.. code::
>   +
>      Heterogeneous Device Archive, HDA = {F1.X, F2.X, ..., FN.Y}
>      where, Fi = Bundle{Host-DeviceBinary, T1-DeviceBinary, T2-DeviceBinary, ...,
>                         Tm-DeviceBinary},
>
> F19189372: image.png <https://reviews.llvm.org/F19189372>

Thanks for noticing this. Please go ahead with your changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110083/new/

https://reviews.llvm.org/D110083



More information about the cfe-commits mailing list