[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 23 14:14:23 PDT 2021


arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGExpr.cpp:103
+    if (!ArraySize) {
+      auto *EBB = AllocaInsertPt->getParent();
+      auto Iter = AllocaInsertPt->getIterator();
----------------
Why is there a special AllocaInsertPt iterator in the first place? Can you avoid any iteration logic by just always inserting at the block start?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110257/new/

https://reviews.llvm.org/D110257



More information about the cfe-commits mailing list