[PATCH] D110128: [Driver] Correctly handle static C++ standard library

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 23 12:14:40 PDT 2021


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581
+      CmdArgs.push_back("--push-state");
+      CmdArgs.push_back("--as-needed");
       if (OnlyLibstdcxxStatic)
----------------
MaskRay wrote:
> The --as-needed change should be dropped from this patch.
> 
`--push-state` should only be added when -Bstatic is added.

Then the old clang-ppc64le-rhel issue may be moot because they probably don't use -static-libstdc++ ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110128/new/

https://reviews.llvm.org/D110128



More information about the cfe-commits mailing list