[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

Edward Jones via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 23 10:28:15 PDT 2021


edward-jones updated this revision to Diff 374609.
edward-jones added a comment.
Herald added a subscriber: achieveartificialintelligence.

Changes here:

  - Merged the separate attributes overlaycall and overlaydata into a single overlay attribute (though I may need to undo this to match the high level document)
  - Fixed to use the correct type of attribute and handle it in a less sloppy way
  - Errors/warnings messages are hopefully more descriptive now
  - Renamed option to -moverlay to match the high level document
  - It's no longer an error to use the attribute without -moverlay, you'll just get "attribute ignored" warnings
- Updated tests

Still to do:

- Writing more tests
- Warn the user to turn on -moverlay as a fix for "attribute ignored" warnings
- Rebase


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109372/new/

https://reviews.llvm.org/D109372

Files:
  clang/include/clang/Basic/Attr.td
  clang/include/clang/Basic/AttrDocs.td
  clang/include/clang/Basic/DiagnosticDriverKinds.td
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Basic/LangOptions.def
  clang/include/clang/Driver/Options.td
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/Driver/ToolChains/Arch/RISCV.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaDeclAttr.cpp
  clang/test/CodeGen/riscv-overlay.c
  clang/test/Driver/riscv-overlay.c
  clang/test/Sema/riscv-overlay-attr.c
  clang/test/Sema/riscv-overlay-namespace.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109372.374609.patch
Type: text/x-patch
Size: 13020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210923/85a3b84a/attachment.bin>


More information about the cfe-commits mailing list