[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

Thu Sep 23 08:21:01 PDT 2021

hsmhsm added inline comments.

================
Comment at: clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp:264
 // CHECK1:       omp.inner.for.cond:
-// CHECK1-NEXT:    [[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4
-// CHECK1-NEXT:    [[TMP8:%.*]] = load i32, i32* [[DOTOMP_UB]], align 4
+// CHECK1-NEXT:    [[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4, !llvm.access.group !15
+// CHECK1-NEXT:    [[TMP8:%.*]] = load i32, i32* [[DOTOMP_UB]], align 4, !llvm.access.group !15
----------------
hsmhsm wrote:
> yaxunl wrote:
> > Is the test updated by a script? If the original test does not check !llvm.access.group, the updated test should not check it either. This makes the test less stable.
> Yes, most of the tests here are updated by script only. Probably I might have missed few command line options to the script. I have not passed any option to the script while updating it. Let me check.
I have used exact command line as in the test file plus extra option "--force-update". But it's presence or absence is not making any difference here. 

But the !llvm.access.group metadata is newly added. And I am not finding anyway of disabling it.

Do you have any idea? or anyone else for that matter? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110257/new/

https://reviews.llvm.org/D110257