[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

In D110257#3015641 <https://reviews.llvm.org/D110257#3015641>, @hsmhsm wrote:

> The logic at https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Utils/InlineFunction.cpp#L2093 assumes that static allocas (within callee) are contiguous.

No, it doesn't make that assumption. That code is an attempt to optimize the linked list splicing, so that batches of contiguous allocas can be spliced over together. I believe the code would still be correct if you removed this inner loop and left behind the outer loop, which iterates over all allocas in the entry block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110257/new/

https://reviews.llvm.org/D110257