[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 22 10:34:18 PDT 2021


craig.topper added inline comments.


================
Comment at: clang/lib/Headers/avx512fp16intrin.h:2972
 #define _mm_mask_fcmadd_round_sch(A, U, B, C, R)                               \
   ((__m128h)__builtin_ia32_selectps_128(                                       \
       (__mmask8)(U & 1),                                                       \
----------------
Why is this intrinsic written like this? We can't evaluate macro arguments like A and U twice. It can cause surprising results.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109658/new/

https://reviews.llvm.org/D109658



More information about the cfe-commits mailing list