[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

Wed Sep 22 09:40:57 PDT 2021

dmgreen added a comment.

In D110258#3015484 <https://reviews.llvm.org/D110258#3015484>, @david-arm wrote:

> Hi @dmgreen, this is specifically being introduced for SVE targets to help make informed cost model decisions regarding the value of vscale - see D110259 <https://reviews.llvm.org/D110259>. We thought that using the "tune-cpu" attribute might be a good way of doing this.

Yeah. I added comments there. It would feel strange to me to have a single part of the tuning features for a cpu based on a `tune-cpu`, where everything else uses the `target-cpu`. We should try and make -mtune work better, but we should aim to do that consistently in a way that doesn't just make thing _more_ confusing!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110258/new/

https://reviews.llvm.org/D110258