[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 22 05:54:49 PDT 2021


martong added a comment.
Herald added a subscriber: manas.

In D86295#2539431 <https://reviews.llvm.org/D86295#2539431>, @steakhal wrote:

> In D86295#2519851 <https://reviews.llvm.org/D86295#2519851>, @ASDenysPetrov wrote:
>
>> What about this change? Did you make more measurements?
>
> IMO it needs more justification and measurement to land it.
>
> If my measurement was correct then it would decrease the readability of the code without any benefit.
> It could be the case due to the allocation strategy & alignment stuff that we don't gain anything by making its layout more compact.

@steakhal Since then we have our fancy csa-testbench based jenkins job(s) to do measurement even on huge projects. Do you think it would make sense to give it another measure with that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86295/new/

https://reviews.llvm.org/D86295



More information about the cfe-commits mailing list